Add ability to use Esc keypress to close modal for document selection #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Made a small change: #2222 Its a fork of this PR, so you'll still be credits for it π |
Contributor
Author
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #2220
What is in this change?
This pull request adds the ability to close the modal dialogue for selecting documents in workspaces using the Escape key on the keyboard. Specifically, the changes include:
This change provides an additional option for users to dismiss the modal, improving the overall user experience and efficiency.
Additional Information
This change addresses a feature request to improve the workflow for users who work with multiple workspaces and need to quickly switch between them. By allowing the Escape key to close the modal, users can reduce mouse movement and streamline their workflow. This change does not introduce any breaking changes or affect existing functionality.
Developer Validations
yarn lintfrom the root of the repo & committed changes