-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
AnythingLLM Chrome Extension #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦llm into chrome-extension
β¦kground.js into models
timothycarambat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some multi-user considerations to make here to prevent inadvertent access or data to those who want to use the extension, but cannot. Rather than deploy something so limiting we should expand scope to support multi-user instances since single-user instances are the default way we support the extension right now.
This review has not touched the extension folder so once this has been addressed we can do another review for just the extension. So far, everything works great for single user.
Other considerations:
- What happens when
adminmakes a key but intended to give it to someone else? It may have been pre-registered and overwritten their extension key!
-> Solution could be a button post-create to "Auto register" or copy the key instead doing the auto-register post creation instantly.
frontend/src/pages/GeneralSettings/BrowserExtensionApiKey/BrowserExtensionApiKeyRow/index.jsx
Outdated
Show resolved
Hide resolved
...nd/src/pages/GeneralSettings/BrowserExtensionApiKey/NewBrowserExtensionApiKeyModal/index.jsx
Outdated
Show resolved
Hide resolved
...nd/src/pages/GeneralSettings/BrowserExtensionApiKey/NewBrowserExtensionApiKeyModal/index.jsx
Outdated
Show resolved
Hide resolved
β¦llm into chrome-extension
β¦when no workspaces
* initial commit for chrome extension * wip browser extension backend * wip frontend browser extension settings * fix typo for browserExtension route * implement verification codes + frontend panel for browser extension keys * reorganize + state management for all connection states * implement embed to workspace * add send page to anythingllm extension option + refactor * refactor connection string auth + update context menus + organize background.js into models * popup extension from main app and save if successful * fix hebrew translation misspelling * fetch custom logo inside chrome extension * delete api keys on disconnect of extension * use correct apiUrl constant in frontend + remove unneeded comments * remove upload-link endpoint and send inner text html to raw text collector endpoint * update readme * fix readme link * fix readme typo * update readme * handle deletion of browser keys with key id and DELETE endpoint * move event string to constant * remove tablename and writable fields from BrowserExtensionApiKey backend model * add border-none to all buttons and inputs for desktop compatibility * patch prisma injections * update delete endpoints to delete keys by id * remove unused prop * add button to attempt browser extension connection + remove max active keys * wip multi user mode support * multi user mode support * clean up backend + show created by in frotend browser extension page * show multi user warning message on key creation + hide context menus when no workspaces * show browser extension options to managers * small backend changes and refactors * extension cleanup * rename submodule * extension updates & docs * dev docker build --------- Co-authored-by: shatfield4 <seanhatfield5@gmail.com>
Pull Request Type
Relevant Issues
resolves #xxx
What is in this change?
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes