1959 filetype filters #2044
Closed
1959 filetype filters #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ adjust the `recursiveLoader` method accordingly.
Contributor
Author
|
@timothycarambat I wasn't sure whether I should have included |
a4399a8 to
24a4d56
Compare
Member
|
@DipFlip only if it was updated with some dependency relevant to the PR |
Contributor
Author
@timothycarambat Ok I did add the |
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #1959
What is in this change?
This PR enables the Github and Gitlab data collectors to accept patterns like
that selects only
pdffiles.It fixes the issue by updating the GithubRepoCollector to use the latest
l@langchain/community/document_loaders/web/githubinstead of the deprecatedlangchain/document_loaders/web/github. Since@langchain/community 0.2.23a bug with theGithubRepoLoaderwas fixed so negative gitignore patterns like!/*is now properly handled.The
GitlabRepoLoaderwas also not handling gitignore patterns with a!properly. This PR makes use of theignorepackage to properly check whether a file is ignored or not by the setignorePaths.Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes