-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
812 add a gitlab connector #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Commit message: Converted GitHub methods to work with GitLab
β¦er/endpoints/extensions/index.js.
β¦n `https` module.
|
Does this work? Do GitHub and GitLab have the same API's? |
|
@timothycarambat yes this is working. You can use the new gitlab data connector to load gitlab repos just like the github connector worked before. The github and gitlab APIs are similar but not identical. Compare for instance the Github: Gitlab: |
|
snuck in a little addition. As mentioned in #1922 , the input field for repo addresses now takes multiple repos which will be collected one by one when |
|
Closing this as I needed to make a bit of changes so moving PR to #1932 - some issues/quirks I came across during review was:
TBH, this is a massive effort and what you did write is a very solid point to start! Youll still get credit for the merge and such, its just on another PR because that is just how Github works when i edit a PR in the π |
|
Thanks for checking it and the refactored implementation is nice! |
|
Thank you for your work, it made doing this about 100x simpler for me to get going - I hadn't used GitLab prior so it would've been a steeper learning curve and taken longer to merge. Thanks again π |
Pull Request Type
Relevant Issues
resolves #812
What is in this change?
This copies the github data connector and ajusts it where necessary to work with gitlab.
Additional Information
I've tested this against public and private gitlab.com repos with access tokens. I have not tested against self-hosted gitlab server.
Developer Validations
yarn lintfrom the root of the repo & committed changes