refactor: convert insert loop to 1 insert stmt #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jwaltz any chance you can run Appreciate you 🙏 |
Contributor
Author
|
@timothycarambat sure thing, linted and added commit. |
timothycarambat
approved these changes
Jun 13, 2023
Member
timothycarambat
left a comment
There was a problem hiding this comment.
You are awesome - this will help resolve a ton of issues 🙏
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
* fix: convert insert loop to 1 insert stmt * chore: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors when inserting a large .docx (
"wordCount": 225518, "token_count_estimate": 47635) file's vectorIds into the document_vectors table:Error: SQLITE_BUSY: database is lockedI took a look at the
bulkInsert()method inserver/models/vectors.jsand noticed it was executingINSERTstatements in a loop. Sqlite supports batch inserts so I converted theINSERTstatement to a single insert with multiple parameters to account for all of the vectorIds.My LSP formatter/linter might have changed a bit of the formatting of the method signatures but I hope the PR is still valuable/valid. Let me know if I can fix anything.
Thanks!