-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
1603 speech to text hotkey #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1603 speech to text hotkey #1771
Conversation
|
Love the idea. I have some feedback currently from a UI/UX perspective. When I press CMD+Enter the mic turns on but is not super obvious my hotkey did that (the icon just gets white for the mic). Then I can speak and I see the words coming in, but then I don't know how to really "stop" the streaming other than shutting up for the silence interval. If I click on the mic icon, it'll auto-send, but if I click the send icon itself it will double-send my query as the mic gets the event to stop listening. Thinking about a UX perspective that makes this less confusing for someone who might find themselves toying with this hot-key combination |
…ks the send button. Updated speech hotkeys.
…thing-llm into 1603-speach-to-text
|
Thanks for the feedback! I've addressed the issue where the query was being double-sent when clicking the mic button or pressing the hotkeys by stopping the TTS session when the send button is clicked and adding an event listener for PROMPT_INPUT_EVENT to check if the user clicks send before the timeout finishes. Additionally, I've changed the hotkeys to CMD+M to avoid interfering with what the ENTER key currently does. For a better user experience, I have added a pulse animation to the mic icon when it is active, making it more obvious when speech recognition is on. All issues with the mic and double-send have been resolved. |
…thing-llm into 1603-speach-to-text
* Added ctrl + enter hotkeys to init speach to text * Ran linter * Fixed speech transcript from being submitted twice when the user clicks the send button. Updated speech hotkeys. * Added pulse animation to mic * Fixed prompt double-send when clicking the send button or ending the TTS session. * Fixed comment grammar * Update mic hotkeys --------- Co-authored-by: Timothy Carambat <rambat1010@gmail.com>
Pull Request Type
Relevant Issues
resolves #1603
What is in this change?
Implemented Ctrl (Cmd on Mac) + 'm' hotkeys to activate the existing React Speech Recognition feature.
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes