-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[FEAT] Confluence Data Connector handles custom Confluence urls #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Confluence Data Connector handles custom Confluence urls #1362
Conversation
…ion to default {subdomain}.atlassian.net ones
TheMattBin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It works well to me
|
@cope LMK you discord username and I can give you contributor badge in there if you dont already have one! |
|
|
so, I made a mistake, here... basically, I was at home over the weekend, on my personal comp, and not able to VPN (don't ask) so I was unable to verify that my company custom URL is also using which, it turns out, we are not 😭 instead, for some reason, our IT clearly had ideas, so we are using @timothycarambat do you think we can solve this, somehow? I do not think that adding the explicit handling for But, maybe if the match fails, we try to use the passed URL as is, assuming it is a proper SPACE URL and not just any PAGE url? The Alternatively, I would have to scrape all the pages myself and push them through the /document/upload API... |
|
It looks like the If it makes no sense, is clunky, and leads to a bad DX you can guarantee it's an Atlassian product: So adding an edge case for that display URL is not crazy it appears. We can either modify the pattern or make it a function that basically runs a list of patterns and returns on first match |
|
OH, awesome! PR comming up 😄 |
|
Created 1423 |
|
@timothycarambat we forgot to adjust line 64: In a human readable form, the baseUrl needs to be only Created 1434 |
…plex-Labs#1362) * chore: confluence data connector can now handle custom urls, in addition to default {subdomain}.atlassian.net ones * chore: formatting as per yarn lint
…plex-Labs#1362) * chore: confluence data connector can now handle custom urls, in addition to default {subdomain}.atlassian.net ones * chore: formatting as per yarn lint
…plex-Labs#1362) * chore: confluence data connector can now handle custom urls, in addition to default {subdomain}.atlassian.net ones * chore: formatting as per yarn lint
…plex-Labs#1362) * chore: confluence data connector can now handle custom urls, in addition to default {subdomain}.atlassian.net ones * chore: formatting as per yarn lint
…plex-Labs#1362) * chore: confluence data connector can now handle custom urls, in addition to default {subdomain}.atlassian.net ones * chore: formatting as per yarn lint
Pull Request Type
Relevant Issues
resolves #1347
What is in this change?
Confluence Data Connector used to only handle the hardcoded
{subdomain}.atlassian.net/wiki/spaces/(:spaceKey)/*. Now it also handles custom confluence URLs like(:subdomain.):domain.:tld/wiki/spaces/(:spaceKey)/*.Developer Validations
yarn lintfrom the root of the repo & committed changes