θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

[FIX] Validate messages schema for gemini provider #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2024
Merged

[FIX] Validate messages schema for gemini provider #1351

merged 2 commits into from
May 11, 2024

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented May 11, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #1328

What is in this change?

  • Fix a bug where extremely long messages get removed from the messages array when sent to the gemini ai provider
  • A validation was created to ensure the schema is valid because gemini expects every user message to be followed by a model message

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue May 11, 2024 that may be closed by this pull request
[BUG]: [GoogleGenerativeAI Error]: Content with role 'user' can't follow 'user'. Valid previous roles: {"user":["model"],"function":["model"],"model":["user","function"],"system":[]} #1328
Closed
@shatfield4
Merge branch 'master' into 1328-bug-googlegenerativeai-error-content-…
d1eeb02 
…with-role-user-cant-follow-user-valid-previous-roles-usermodelfunctionmodelmodeluserfunctionsystem
@timothycarambat timothycarambat merged commit 948ac8a into master May 11, 2024
@timothycarambat timothycarambat deleted the 1328-bug-googlegenerativeai-error-content-with-role-user-cant-follow-user-valid-previous-roles-usermodelfunctionmodelmodeluserfunctionsystem branch May 11, 2024 00:33
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Jul 31, 2024
@shatfield4
[FIX] Validate messages schema for gemini provider (Mintplex-Labs#1351)
0e1066e 
validate messages schema for gemini provider
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 1, 2024
@shatfield4
[FIX] Validate messages schema for gemini provider (Mintplex-Labs#1351)
4f33205 
validate messages schema for gemini provider
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 2, 2024
@shatfield4
[FIX] Validate messages schema for gemini provider (Mintplex-Labs#1351)
12817f9 
validate messages schema for gemini provider
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 3, 2024
@shatfield4
[FIX] Validate messages schema for gemini provider (Mintplex-Labs#1351)
4786f39 
validate messages schema for gemini provider
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
@shatfield4
[FIX] Validate messages schema for gemini provider (Mintplex-Labs#1351)
3d77749 
validate messages schema for gemini provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@shatfield4 @timothycarambat