θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

[FIX] Workspace settings not showing updated fields #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

[FIX] Workspace settings not showing updated fields #1344

merged 1 commit into from
May 13, 2024

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented May 10, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #1284

What is in this change?

  • Fixes bug where if user was to update a setting in workspace settings and switch tabs it would show the previous settings from before the user pressed update workspace

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue May 10, 2024 that may be closed by this pull request
[BUG]: Workspace setting fields not showing current configuration #1284
Closed
@timothycarambat timothycarambat added the PR:needs review Needs review by core team label May 10, 2024
@timothycarambat timothycarambat merged commit 2fabc84 into master May 13, 2024
@timothycarambat timothycarambat deleted the 1284-bug-workspace-setting-fields-not-showing-current-configuration branch May 13, 2024 19:59
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Jul 31, 2024
@shatfield4
[FIX] Workspace settings not showing updated fields (Mintplex-Labs#1344)
771007c 
add tab to dependency array in useEffect to reload settings on tab change
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 1, 2024
@shatfield4
[FIX] Workspace settings not showing updated fields (Mintplex-Labs#1344)
62983c8 
add tab to dependency array in useEffect to reload settings on tab change
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 2, 2024
@shatfield4
[FIX] Workspace settings not showing updated fields (Mintplex-Labs#1344)
bd27970 
add tab to dependency array in useEffect to reload settings on tab change
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 3, 2024
@shatfield4
[FIX] Workspace settings not showing updated fields (Mintplex-Labs#1344)
f6c0fdd 
add tab to dependency array in useEffect to reload settings on tab change
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
@shatfield4
[FIX] Workspace settings not showing updated fields (Mintplex-Labs#1344)
6e14a24 
add tab to dependency array in useEffect to reload settings on tab change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels

PR:needs review Needs review by core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Workspace setting fields not showing current configuration

3 participants

@shatfield4 @timothycarambat