θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

Conversation

@shatfield4
Copy link
Collaborator

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #992

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Implement new CTAButton component to be reused in all settings pages
  • Fix UI for Security Settings, Privacy & Data-Handling pages to match all other settings pages

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to commit the @components/lib/CTAButton file? Also why does frontend/src/pages/WorkspaceSettings/Members/index.jsx not have any class stylings?

@timothycarambat timothycarambat added the PR:needs review Needs review by core team label Apr 5, 2024
@timothycarambat timothycarambat merged commit 657be7e into master Apr 5, 2024
@timothycarambat timothycarambat deleted the 992-feat-normalize-all-cta-buttons-in-settings-menus branch April 5, 2024 20:54
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
* members workspace settings menu and admin users UI updates

* implement CTAButton in all general/admin settings + ui tweaks

* move CTAButton to components/lib

* fix UI for security page to match rest of all settings pages

* UX improvements

* add CTAButton component

* prevent components folder from being ignored

* patch some UI fixes

---------

Co-authored-by: timothycarambat <rambat1010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:needs review Needs review by core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Normalize all CTA buttons in settings menus

3 participants