θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

[FEAT] Thread bulk edit UX improvements #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024
Merged

[FEAT] Thread bulk edit UX improvements #1520

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
425a1c0
update thread bulk edit ux to hold cmd/ctrl to appear + rename defaul…
shatfield4 May 23, 2024
8edbede
revert new thread defualt name change
shatfield4 May 23, 2024
e2365a5
unset undelete threads
timothycarambat May 23, 2024
44d6096
comment
timothycarambat May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,17 @@ export default function ThreadContainer({ workspace }) {
fetchThreads();
}, [workspace.slug]);

// Enable toggling of meta-key (ctrl on win and cmd/fn on others)
// Enable toggling of bulk-deletion by holding meta-key (ctrl on win and cmd/fn on others)
useEffect(() => {
const handleKeyDown = (event) => {
if (["Control", "Meta"].includes(event.key)) {
setCtrlPressed((prev) => !prev);
setCtrlPressed(true);
}
};

const handleKeyUp = (event) => {
if (["Control", "Meta"].includes(event.key)) {
setCtrlPressed(false);
// when toggling, unset bulk progress so
// previously marked threads that were never deleted
// come back to life.
Expand All @@ -37,9 +43,13 @@ export default function ThreadContainer({ workspace }) {
);
}
};

window.addEventListener("keydown", handleKeyDown);
window.addEventListener("keyup", handleKeyUp);

return () => {
window.removeEventListener("keydown", handleKeyDown);
window.removeEventListener("keyup", handleKeyUp);
};
}, []);

Expand All @@ -56,7 +66,6 @@ export default function ThreadContainer({ workspace }) {
const slugs = threads.filter((t) => t.deleted === true).map((t) => t.slug);
await Workspace.threads.deleteBulk(workspace.slug, slugs);
setThreads((prev) => prev.filter((t) => !t.deleted));
setCtrlPressed(false);
};

function removeThread(threadId) {
Expand Down Expand Up @@ -89,6 +98,7 @@ export default function ThreadContainer({ workspace }) {
)
? threads.findIndex((thread) => thread?.slug === threadSlug) + 1
: 0;

return (
<div className="flex flex-col" role="list" aria-label="Threads">
<ThreadItem
Expand Down