θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

[FIX] First time pinned document modal #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

[FIX] First time pinned document modal #1678

merged 1 commit into from
Jun 13, 2024

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jun 13, 2024 •
edited
Loading

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #1677

What is in this change?

  • Added noPortal to the modal wrapper component for the first time document pinning modal
  • Modal was appearing behind the ManageWorkspace component and was not visible

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue Jun 13, 2024 that may be closed by this pull request
[BUG]: First time pinned document modal hidden #1677
Closed
@timothycarambat timothycarambat merged commit 5676e12 into master Jun 13, 2024
@timothycarambat timothycarambat deleted the 1677-bug-first-time-pinned-document-modal-hidden branch June 13, 2024 21:43
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Jul 31, 2024
@shatfield4
[FIX] First time pinned document modal (Mintplex-Labs#1678)
8c738db 
fix first time pinned document modal
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 1, 2024
@shatfield4
[FIX] First time pinned document modal (Mintplex-Labs#1678)
b3494b8 
fix first time pinned document modal
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 2, 2024
@shatfield4
[FIX] First time pinned document modal (Mintplex-Labs#1678)
c6d0ff4 
fix first time pinned document modal
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 3, 2024
@shatfield4
[FIX] First time pinned document modal (Mintplex-Labs#1678)
5e383d8 
fix first time pinned document modal
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
@shatfield4
[FIX] First time pinned document modal (Mintplex-Labs#1678)
1164f13 
fix first time pinned document modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: First time pinned document modal hidden

3 participants

@shatfield4 @timothycarambat