θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

[FIX] Delete SQL agent connection bug fix #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[FIX] Delete SQL agent connection bug fix #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/DBConnection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const DB_LOGOS = {
"sql-server": MSSQLLogo,
};

export default function DBConnection({ connection, onRemove }) {
export default function DBConnection({ connection, onRemove, setHasChanges }) {
const { database_id, engine } = connection;
function removeConfirmation() {
if (
Expand All @@ -20,6 +20,7 @@ export default function DBConnection({ connection, onRemove }) {
return false;
}
onRemove(database_id);
setHasChanges(true);
}

return (
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/pages/WorkspaceSettings/AgentConfig/SQLConnectorSelection/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export default function AgentSQLConnectorSelection({
settings,
toggleSkill,
enabled = false,
setHasChanges,
}) {
const { isOpen, openModal, closeModal } = useModal();
const [connections, setConnections] = useState(
Expand Down Expand Up @@ -72,6 +73,7 @@ export default function AgentSQLConnectorSelection({
})
);
}}
setHasChanges={setHasChanges}
/>
))}
<button
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export default function WorkspaceAgentConfiguration({ workspace }) {
skills={agentSkills}
toggleAgentSkill={toggleAgentSkill}
settings={settings}
setHasChanges={setHasChanges}
/>
{hasChanges && (
<button
Expand Down Expand Up @@ -143,7 +144,7 @@ function LoadingSkeleton() {
);
}

function AvailableAgentSkills({ skills, settings, toggleAgentSkill }) {
function AvailableAgentSkills({ skills, settings, toggleAgentSkill, setHasChanges }) {
return (
<div>
<div className="flex flex-col mb-8">
Expand Down Expand Up @@ -211,6 +212,7 @@ function AvailableAgentSkills({ skills, settings, toggleAgentSkill }) {
settings={settings}
toggleSkill={toggleAgentSkill}
enabled={skills.includes("sql-agent")}
setHasChanges={setHasChanges}
/>
</div>
</div>
Expand Down