θΏ™ζ˜―indexlocζδΎ›ηš„ζœεŠ‘οΌŒδΈθ¦θΎ“ε…₯任何密码
Skip to content

[FIX] Delete SQL agent connection bug fix #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

[FIX] Delete SQL agent connection bug fix #1635

merged 1 commit into from
Jun 7, 2024

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jun 7, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #1616

What is in this change?

  • Fix a bug where when deleting a SQL agent connection, it does not delete the connection
  • Now after deletion, the Update workspace agent button appears and allows them to save the deletion

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue Jun 7, 2024 that may be closed by this pull request
[BUG]: can't delete database connection of SQL agent #1616
Closed
@timothycarambat timothycarambat merged commit 48b7d54 into master Jun 7, 2024
@timothycarambat timothycarambat deleted the 1616-bug-cant-delete-database-connection-of-sql-agent branch June 7, 2024 19:03
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Jul 31, 2024
@shatfield4
[FIX] Delete SQL agent connection bug fix (Mintplex-Labs#1635)
fa6873a 
fix update agent settings button not appearing when deleting sql connection
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 1, 2024
@shatfield4
[FIX] Delete SQL agent connection bug fix (Mintplex-Labs#1635)
ead951c 
fix update agent settings button not appearing when deleting sql connection
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 2, 2024
@shatfield4
[FIX] Delete SQL agent connection bug fix (Mintplex-Labs#1635)
b0be2e9 
fix update agent settings button not appearing when deleting sql connection
CrackerCat pushed a commit to CrackerCat/anything-llm that referenced this pull request Aug 3, 2024
@shatfield4
[FIX] Delete SQL agent connection bug fix (Mintplex-Labs#1635)
0dee06a 
fix update agent settings button not appearing when deleting sql connection
cabwds pushed a commit to cabwds/anything-llm that referenced this pull request Jul 3, 2025
@shatfield4
[FIX] Delete SQL agent connection bug fix (Mintplex-Labs#1635)
ac78134 
fix update agent settings button not appearing when deleting sql connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: can't delete database connection of SQL agent

3 participants

@shatfield4 @timothycarambat