fix: resolve Firefox search icon overlapping placeholder text #4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase input left padding from pl-4 to pl-9 to provide clearance - Remove redundant placeholder:pl-4 class - Ensures 24px spacing between search icon and text content
angelplusultra
approved these changes
Sep 23, 2025
Contributor
angelplusultra
left a comment
There was a problem hiding this comment.
Fixed shifting of svg
shatfield4
approved these changes
Sep 23, 2025
Collaborator
shatfield4
left a comment
There was a problem hiding this comment.
LGTM (reviewed with Marcello on call)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4387
What is in this change?
pl-4topl-9to provide sufficient clearance between the search icon and text content, ensuring proper visual spacing across all browsers.Additional Information