feat: enable HTML uploads from UI #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #418
Member
Author
|
|
collector/scripts/watch/convert/as_html.pyInstead of using kwargs.get() for each argument in the as_html function, it would be more Pythonic and readable to define these arguments in the function signature itself. This way, you can provide default values for each argument and it will be easier to understand what arguments the function expects. def as_html(directory='hotdir', filename=None, ext='.html', remove_on_complete=False):
fullpath = f"{directory}/{filename}{ext}"
... |
Comment on lines
+8
to
+13
| def as_html(**kwargs): | ||
| parent_dir = kwargs.get('directory', 'hotdir') | ||
| filename = kwargs.get('filename') | ||
| ext = kwargs.get('ext', '.html') | ||
| remove = kwargs.get('remove_on_complete', False) | ||
| fullpath = f"{parent_dir}/{filename}{ext}" |
There was a problem hiding this comment.
The function signature has been updated to include the optional arguments directly, with their default values. This makes the function more readable and maintainable, as it's easier to understand what arguments the function expects.
Suggested change
| def as_html(**kwargs): | |
| parent_dir = kwargs.get('directory', 'hotdir') | |
| filename = kwargs.get('filename') | |
| ext = kwargs.get('ext', '.html') | |
| remove = kwargs.get('remove_on_complete', False) | |
| fullpath = f"{parent_dir}/{filename}{ext}" | |
| def as_html(directory='hotdir', filename=None, ext='.html', remove_on_complete=False): | |
| fullpath = f"{directory}/{filename}{ext}" | |
| ... |
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #418