fix(server): correct Qdrant batching logic for large uploads #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Changed the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4544
What is in this change?
This change corrects the batching logic in the Qdrant vector provider (index.js).
Previously, the code would attempt to upsert all generated vector chunks in a single request. This caused an error when the number of chunks exceeded Qdrant's batch limit (e.g., >500).
The fix ensures the code properly iterates through the pre-defined chunks and sends them in smaller, valid batches, allowing for the successful embedding of documents with a large number of chunks.
Additional Information
This issue was discovered when a less aggressive chunking strategy was used on a document, increasing the chunk count from ~200 to ~2000, which triggered the bug.
Developer Validations
yarn lintfrom the root of the repo & committed changes