Fix: File pulling fails with uppercase URL characters #4516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owercase while preserving path case
…uppercase-characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4514
What is in this change?
This PR fixes a bug during the URL file pulling process where a URL has uppercase characters and we were converting the URL to lowercase, this was resulting in 404 not found errors being thrown when fetching the content type of the URL.
Additional Information
Additionally addresses the
path.basenameuse indownloadURIToFilefunction causing weird output names in RAG uploader.Developer Validations
yarn lintfrom the root of the repo & committed changes