fix: youtube transcript collector not work well with non en or non asr caption #4442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-non-asr-language
…uage' of github.com:AoiYamada/anything-llm into pr-4442-branch
Member
|
Beautiful PR, almost shed a tear. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #1770 is a real bug for non asr caption or non en caption because the values are hardcoded.
For example:
https://www.youtube.com/watch?v=D111ao6wWH0
this video has a "zh-HK" language caption with empty string caption kind "" instead of "asr".
Pull Request Type
Relevant Issues
resolves #1770
What is in this change?
Get the caption info of the YouTube video, analyze the track info, and select the preferred transcript info as params to fetch the transcript.
Additional Information
Before the fix, non asr non en caption causes
Transcript segments not found in responseerror:After the fix, transcript could be fetched:
Developer Validations
yarn lintfrom the root of the repo & committed changes