Sanitize Metadata Before PG Vector Database Insertion #4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method recursively sanitizes values intended for JSONB storage, removing disallowed control characters and ensuring safe insertion into PostgreSQL. The method is integrated into the vector insertion process to sanitize metadata before database operations.
Member
timothycarambat
left a comment
There was a problem hiding this comment.
Add a test suite for sanitizeForJsonb to server/__tests__/utils/vectorDbProviders/pgvector/index.js so we can validate this against known valid/invalid cases.
timothycarambat
previously requested changes
Sep 26, 2025
Member
timothycarambat
left a comment
There was a problem hiding this comment.
Add a test suite for sanitizeForJsonb to server/__tests__/utils/vectorDbProviders/pgvector/index.js so we can validate this against known valid/invalid cases.
This commit introduces a comprehensive test suite for the PGVector.sanitizeForJsonb method, ensuring it correctly handles various input types, including null, undefined, strings with disallowed control characters, objects, arrays, and Date objects. The tests verify that the method sanitizes inputs without mutating the original data structures.
Contributor
Author
Fix in 0eb23b0 |
Member
|
Beautiful work - great test case coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4339
What is in this change?
This PR adds a JSONB-safe sanitizer to the PGVector provider to address βunsupported Unicode escape sequenceβ errors that occur when inserting metadata containing disallowed control characters (most notably the NUL character, \u0000). Certain sources (e.g., some PDFs) can produce chunks with these control characters in the extracted text, causing Postgres to reject the jsonb payload.
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes