这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@angelplusultra
Copy link
Contributor

@angelplusultra angelplusultra commented Sep 22, 2025

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4413

What is in this change?

This PR introduces a change to every LLM and Embedder class in /server where this.constructor.name was being used for debug logging purposes. Over 30 classes now contain a className property with the name of the class statically assigned as a string inside the constructor, and then used in the private log function of each class.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@angelplusultra angelplusultra linked an issue Sep 22, 2025 that may be closed by this pull request
@angelplusultra angelplusultra added the PR:needs review Needs review by core team label Sep 24, 2025
@timothycarambat timothycarambat merged commit 6855bbf into master Sep 26, 2025
1 check passed
@timothycarambat timothycarambat deleted the 4413-update-class-name-logging branch September 26, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:needs review Needs review by core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE]: Update this.constructor.name usage

3 participants