这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@angelplusultra
Copy link
Contributor

@angelplusultra angelplusultra commented Sep 22, 2025

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4401

What is in this change?

This PR introduces an HTTP logging middleware layer in both express servers (/server and /collector) that logs:

  • The Request Method ( ex. GET)
  • The Request Path (ex. /workspace/my-workspace/stream-chat)
  • The Response Status Code (ex. 200)
  • An optional time log of the moment the response is sent.
image

With time log:

image

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

- Introduced httpLogger middleware to log HTTP requests and responses.
- Enabled logging only in development mode to assist with debugging.
@angelplusultra angelplusultra linked an issue Sep 22, 2025 that may be closed by this pull request
@angelplusultra angelplusultra marked this pull request as draft September 22, 2025 21:48
@angelplusultra angelplusultra marked this pull request as ready for review September 22, 2025 22:02
@angelplusultra angelplusultra added the PR:needs review Needs review by core team label Sep 24, 2025
Copy link
Member

@timothycarambat timothycarambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make optional, even in development. I would turn this on as a debug tool, but not have it on all the time so I can get clean logs when doing other items.

@timothycarambat timothycarambat removed their assignment Sep 26, 2025
@timothycarambat timothycarambat removed the PR:needs review Needs review by core team label Sep 26, 2025
@angelplusultra angelplusultra added the PR: Requested Changes Changes have been requested by a reviewer label Sep 26, 2025
@angelplusultra angelplusultra added PR:needs review Needs review by core team and removed PR: Requested Changes Changes have been requested by a reviewer labels Sep 26, 2025
@timothycarambat timothycarambat merged commit eb77876 into master Sep 29, 2025
1 check passed
@timothycarambat timothycarambat deleted the 4401-dev-http-logger branch September 29, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:needs review Needs review by core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Dev HTTP Logger

3 participants