Install patch-package in /collector and Apply Patch to Fix EPub Upload Bug
#4630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4582
What is in this change?
This PR
patch-packageas a dependency inside/collector, an NPM package that allows for easy patching of code insidenode_modules.patch-packageas a yarn postinstall script insidepackage.jsonepub2library to theEPubclass to ensuretitleis a string before calling.trim()Additional Information
Yarn has native lifecycle scripts, one of which is called
postinstallwhich runs after packages are added, removed, etc. Read more here.The
postinstallscript this PR adds callspatch-package, which looks at thepatchesdirectory and applies the git diffs it discovers inside there.Example Execution Flow
yarn installoryarnis executedpostinstallscript is executed which runspatch-packagepatch-packageapplies git diffs inside the relativepatchesdirectory to code innode_modulesDeveloper Validations
yarn lintfrom the root of the repo & committed changes