Check for invalid VecDB value, log/toast error #4626
Closed
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This "bug" is only possible by someone opening the ENV file directly, typing in an incorrect value, and then opening the app. It is not possible to select an invalid provider from the UI. Additionally, this only patches the UI crash and not the underlying issue since even if the UI is right we should failover to LanceDB on the backend as well - not just show that on the frontend. The user can then wind up seeing lanceDB in the frontend due to an invalid value, but the backend upserts still fail! |
timothycarambat
added a commit
that referenced
this pull request
Nov 19, 2025
resolves #4640 closes #4626
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4606
What is in this change?
Checks if vecDB selection from ENV is valid, logs and toasts when invalid and falls back onto LanceDB as the selection with unsaved changes.
Developer Validations
yarn lintfrom the root of the repo & committed changes