这是indexloc提供的服务，不要输入任何密码
Skip to content

Admin shouldn't be hardcoded, thanks Keenan... #18153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

Admin shouldn't be hardcoded, thanks Keenan... #18153

merged 1 commit into from
Oct 31, 2018

Conversation

@d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 31, 2018 •
edited
Loading

It's from #18106 (comment).

Mea maxima culpa.

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 31, 2018

@miq-bot add_label hammer/yes

@d-m-u d-m-u force-pushed the fixing_hardcoded_admin_in_retirement_mixin branch from e336f38 to 504df5a Compare October 31, 2018 20:07
@kbrock kbrock merged commit 89adf41 into ManageIQ:master Oct 31, 2018
@kbrock kbrock self-assigned this Oct 31, 2018
@kbrock kbrock added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 31, 2018
simaishi pushed a commit that referenced this pull request Nov 1, 2018
@kbrock @simaishi
Merge pull request #18153 from d-m-u/fixing_hardcoded_admin_in_retire…
d615be1 
…ment_mixin

This shouldn't be hardcoded, thanks Keenan...

(cherry picked from commit 89adf41)
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2018

Hammer backport details:

$ git log -1
commit d615be12f24d8ba641f00f87938e3680f320a9fc
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Wed Oct 31 16:41:22 2018 -0400

    Merge pull request #18153 from d-m-u/fixing_hardcoded_admin_in_retirement_mixin
    
    This shouldn't be hardcoded, thanks Keenan...
    
    (cherry picked from commit 89adf4149f5759b06028a6ee0ad7dc270986e12e)

@d-m-u d-m-u changed the title This shouldn't be hardcoded, thanks Keenan... Admin shouldn't be hardcoded, thanks Keenan... Nov 1, 2018
@d-m-u d-m-u deleted the fixing_hardcoded_admin_in_retirement_mixin branch February 1, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kbrock kbrock

Labels

hammer/backported refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@d-m-u @simaishi @kbrock @miq-bot