Optimize fontification by avoiding recalculating a constant regexp #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexp-opt can be slow because it also tries to optimize the
regexp. For example:
(regexp-opt (list "aaa" "abb"))
;; -> "\\(?:a\\(?:aa\\|bb\\)\\)"
So it shouldn't be run every time a fontification happens.
This does mean that when
lisp-extra-font-lock-loop-keywords-with-var and
lisp-extra-font-lock-loop-keywords are changed, the changes would
only take effect after the file is reloaded. This shouldn't be a
problem though, as these variables are not meant to be changed, and
are unlikely to be changed anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements / fixes #8.
regexp-opt can be slow because it also tries to optimize the regexp. For example:
So it shouldn't be run every time a fontification happens.
This does mean that when
lisp-extra-font-lock-loop-keywords-with-varandlisp-extra-font-lock-loop-keywordsare changed, the changes would only take effect after the file is reloaded. This shouldn't be a problem though, as these variables are not meant to be changed, and are unlikely to be changed anyways.