Resolve #558: Enable configurable mobile views and auto-scroll #586
Conversation
|
@labmecanicatec On the 2nd commit, can you split the commit message so that there is a subject line and then the body below that? Something like: Like this: Try to keep the subject line to no more than 70-75 characters if possible. Then put the additional detail of what and why in the body of the commit message. Thanks! |
This commit enables device detection (mobile/tablet/desktop) only when the load.mobile.views configuration is set to true. Additionally, the AutoScrollToday variable is created from the auto.scroll.today config value. This allows the frontend to scroll to the current day dynamically based on this setting.
There was a problem hiding this comment.
Pull Request Overview
This PR enables configurable mobile views and auto-scroll functionality in the schedule feature, allowing admins to toggle these behaviors via new configuration options.
- Introduces new config keys for mobile views and auto-scroll to today.
- Implements auto-scroll functionality in the schedule template and associated JavaScript.
- Updates the page initialization to trigger mobile device detection only when enabled and to pass the auto-scroll setting to the frontend.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tpl/Schedule/schedule.tpl | Adds a new auto-scrollToday property to the template settings. |
| lib/Config/ConfigKeys.php | Introduces new configuration keys for mobile views and auto-scroll. |
| config/config.dist.php | Provides default configuration values for mobile views and auto-scroll. |
| config/config.devel.php | Mirrors the production config with new settings for mobile views and auto-scroll. |
| Web/scripts/schedule.js | Implements auto-scroll logic to scroll to today if enabled. |
| Pages/Page.php | Adds condition-based mobile detection and passes auto-scroll configuration to the frontend. |
Done! |
JohnVillalovos
left a comment
There was a problem hiding this comment.
LGTM.
Thanks @labmecanicatec
New settings:
Allows admins to enable mobile views and auto-scroll to today in the schedule.