这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@lucs7
Copy link
Contributor

@lucs7 lucs7 commented May 21, 2025

to make the Trumbowyg integration work as intended and allow html edits in the description and note field, the editing popover needs to remain open on link editing as this creates another popover.

old behaviour

  1. description editing button opened description editing form
  2. click on insert link closed the description editing form
  3. clicking outside the editing form closed editing form

new behaviour

  1. description editing button opened description editing form
  2. click on insert link keeps the description editing form open and overlays the link editor
  3. clicking outside the editing form does not close editing form

and a small fix for the URIScriptValidator.php for an error in the Debug logger

{indicator}
</div>
</div>
<div class="clearfix border-bottom mb-3">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance that this could be broken up so that the reformat happens in one commit, and the change happens in another one?

As it is right now it is very difficult to know what has changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is due to the autoformatter. i will update the commit later without the reformatting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnVillalovos JohnVillalovos changed the title keep description and note edit from closing when loosing focus keep description and note edit from closing when losing focus May 22, 2025
Copy link
Contributor

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucs7

@JohnVillalovos JohnVillalovos merged commit fa0c6a3 into LibreBooking:develop May 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants