这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix for url validation issue with public schedule/calendar #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

Fix for url validation issue with public schedule/calendar #570

merged 2 commits into from
May 21, 2025

Conversation

@lucs7
Copy link
Contributor

@lucs7 lucs7 commented May 21, 2025 •
edited by JohnVillalovos
Loading

  • Updated logic for URI and param validation
  • added unit test
  • added URI validation to Schedule and Calendar page

open tasks

  • should be tested to validate functionality of param validation works everywhere
  • implementation should be not for each page but more central in routing to prevent repetition on every page
  • RouteParamsKeys are only available for CALENDAR and SCHEDULE but might be implemented for other pages/forms

Closes: #563

lucs7 added 2 commits May 21, 2025 16:21
@lucs7
cleanup
c4d2011
@lucs7
Updated Xss and param validation logic and implementation to work wit…
f4e9524 
…h guest sites. added unit tests to validate the logic
JohnVillalovos
JohnVillalovos approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucs7 . LGTM.

@JohnVillalovos JohnVillalovos merged commit a044870 into LibreBooking:develop May 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Guest views are being redirected to non-existent paths

2 participants

@lucs7 @JohnVillalovos