Add Clap crate and a binary #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date: Wed May 18 06:34:17 2022 +0200
LesnyRumcajs
requested changes
May 19, 2022
Owner
LesnyRumcajs
left a comment
There was a problem hiding this comment.
Nice, thanks! I was using it only with this :)
src/bin/wake.rs
Outdated
| fn main() { | ||
| let args = CmdArgs::parse(); | ||
| if let Some(m) = args.mac { | ||
| let mut sep: char = '/'; |
Owner
There was a problem hiding this comment.
I believe you could shorten it to something along the lines of let sep = m.chars().find(|ch| ch == ':' || ch == '-').unwrap_or('/');. What do you think?
Author
There was a problem hiding this comment.
Yes! sure. To be honest, this is not the best solution.
Didn't know about the wolwaker... :-)
Author
|
ok changed as you suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.