这是indexloc提供的服务,不要输入任何密码
Skip to content

Bump mbknor-jackson-jsonschema to 2.13 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lfgcampos
Copy link
Contributor

@lfgcampos lfgcampos commented Dec 18, 2024

Bumping mbknor-jackson-jsonschema to 2.13.


But, to expand on the issue:

Dependency in case:

<dependency>
    <groupId>com.kjetland</groupId>
    <artifactId>mbknor-jackson-jsonschema_2.12</artifactId>
    <version>1.0.39</version>
    <exclusions>
        <exclusion>
            <artifactId>jackson-databind</artifactId>
            <groupId>com.fasterxml.jackson.core</groupId>
        </exclusion>
    </exclusions>
</dependency>

As far I could see, this dependency is used to generate a json schema when using "advanced options" such as function calls.

For example, when using this together with Quarkus, it breaks because the dependency is build for Scala up to 2.13.

Implemented in Scala (Built for 2.10, 2.11, 2.12 and 2.13)

When running this with current dependency (v 2.12) it breaks and need to be removed and 2.13 added manually.
But, to make it worse, the dependency is quite old and probably not maintained anymore: last release was done more than 4y ago.

openai-java, the official SDK for OpenAI was also released recently and they don't use this dependency.
It might be worth checking their code and understanding how they have done it and improve this lib with that.

@Lambdua
Copy link
Owner

Lambdua commented Dec 19, 2024

I will upgrade to the new version first, and I also see that the official library has been released, which is good news🙂

@Lambdua Lambdua merged commit e0a68f3 into Lambdua:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants