add ToolCallFileSearch class to hold the file search results #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
The assistant streaming feature may encounter a JSON parser exception when parsing RunStepDelta for the file search tool.
The error occurred:
The main issue is that the file search in ToolCall.java is defined as a map while it should be an object.
openai4j/api/src/main/java/com/theokanning/openai/assistants/run/ToolCall.java
Lines 38 to 42 in efbba5d
Sample data for thread.run.step.delta:
{ "id": "step_xxx", "object": "thread.run.step.delta", "delta": { "step_details": { "type": "tool_calls", "tool_calls": [ { "index": 0, "id": "call_xxx", "type": "file_search", "file_search": { "ranking_options": { "ranker": "default_2024_08_21", "score_threshold": 0 }, "results": [] } } ] } } }Sample data for thread.run.step:
{ "id": "step_xxx", "object": "thread.run.step", "created_at": 1728264590, "run_id": "run_xxx", "assistant_id": "asst_xxx", "thread_id": "thread_xxx", "type": "tool_calls", "status": "completed", "cancelled_at": null, "completed_at": 1728264592, "expires_at": 1728265189, "failed_at": null, "last_error": null, "step_details": { "type": "tool_calls", "tool_calls": [ { "id": "call_xxx", "type": "file_search", "file_search": { "ranking_options": { "ranker": "default_2024_08_21", "score_threshold": 0 }, "results": [ { "file_id": "file-xxx", "file_name": "xxx.md", "score": 0.36565948875785104 }, { "file_id": "file-xxx", "file_name": "yyy.md", "score": 0.03818400468604836 } ] } } ] }, "usage": { "prompt_tokens": 765, "completion_tokens": 30, "total_tokens": 795 } }This pull request adds the missing class definition based on the documentation and the Python reference implementation to resolve the issue.
Which issue(s) this PR fixes:
Fixes #61
Brief changelog