Allow a ThreeJS object to be reused for the lifetime of the app. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Flutter Web. Replaced _getJpegDimensions with _getDimensions to support all image types when retrieving dimensions.
Knightro63
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on web, creating a
ThreeJSobject also creates a new WebGL context instance and there's a hard limit of the number of WebGL contexts that can be created on web. The changes in this PR allow the web apps that depend on thethree_jspackage to only create aThreeJSobject once and reuse it throughout the lifetime of the app.The PR also changes the way image dimensions are retrieved. Previously only JPEG image were supported through the use of
_getJpegDimensions. This is now replaced with_getDimensions, that allow any kind of image to be used.