fix DexWriter for hiddenapi section #816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lanchon
reviewed
May 13, 2021
Lanchon
reviewed
May 13, 2021
Author
|
successfully pushed refactors based on @Lanchon 's suggestions. Apologies for the bad casts and whatnot, java isn't my main language so I was attempting the functionality to work on a first pass and didn't cleanup. |
|
@JesusFreke Will it be merged? |
SolidEva
added a commit
to SolidEva/Apktool
that referenced
this pull request
Aug 27, 2021
to fix creating invalid dex files
|
+1 to getting this merged, confirmed this fixes the issue |
|
@JesusFreke This pr is really helpful |
|
Please review this PR, it's important for Apktool's issue, @JesusFreke |
Owner
|
Thanks. Squashed and merged as 3436508 |
ShaDisNX255
referenced
this pull request
in ShaDisNX255/NcX_Stock
Nov 29, 2023
Special thanks to @ddavidavidd at Telegram for providing this fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #815