Add MappedByteBuffer support for DexBackedDexFile. #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusFreke
requested changes
Jan 15, 2020
dexlib2/src/main/java/org/jf/dexlib2/dexbacked/DexBackedDexFile.java
Outdated
Show resolved
Hide resolved
JesusFreke
requested changes
Jan 23, 2020
| this(opcodes, buf, 0, true); | ||
| } | ||
|
|
||
| public DexBackedDexFile(@Nullable Opcodes opcodes, @Nonnull MappedDexBuffer buf) { |
Owner
There was a problem hiding this comment.
I don't think this constructor is needed now?
| @@ -0,0 +1,104 @@ | |||
| package org.jf.dexlib2.dexbacked; | |||
Owner
There was a problem hiding this comment.
As per my last comments, I don't think class needs to be submitted to the smali repo
| * @param offset The offset within the buffer to the beginning of the dex header | ||
| * @return True if the magic value is valid | ||
| */ | ||
| public static boolean verifyMagic(MappedByteBuffer buf, int offset) { |
Owner
There was a problem hiding this comment.
I don't think any of the changes in this file are needed any longer?
Owner
|
Thanks, I squashed the commits, removed some remaining unneeded changes, and reworded the commit message a bit to reflect the recent changes. Committed as b7a1052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To let DexBackedDexFile be able to read in DEX file using MappedByteBuffer.