Add Module Json #87
Merged
Add Module Json #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to read module information from a JSON manifest produced by Terraform Cloud and integrates it into module resolution logic.
- Introduces ReadModuleJson and ReadModuleJsonForDir functions to parse a modules.json file.
- Updates GetLocalModules to use parsed module data when the module source matches Terraform Cloud patterns.
- Adjusts tests and dependency versions accordingly.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/modules.go | New module JSON snapshot parsing and mapping implementations. |
| src/data.go | Updated resource functions to utilize module JSON data. |
| src/data_test.go | Modified tests to pass module JSON to the GetLocalModules function. |
| go.mod | Updated dependency versions to support new functionality. |
Comments suppressed due to low confidence (1)
src/modules.go:48
- [nitpick] Consider renaming the variable 'new' to a more descriptive name such as 'moduleRecords' to improve code readability.
new := make(ModuleJson)
Owner
|
thanks for the contribution! could you add some tests for the new code file? ta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read module from the json file produced by Terraform in case of Terraform Cloud.
Starting with
app.terraform.io