dev!: cleanup and update compatibility with abilities-api v0.1.0
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates compatibility with the initial v0.1.0 release of the abilities-api by refactoring the factory pattern to accept WP_Ability instances directly instead of ability names.
- Updated
RegisterAbilityAs*::make()methods to takeWP_Abilityobjects instead of strings - Made internal factory methods private and removed public validation methods
- Added validation at the server level before creating factory instances
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| includes/Core/McpServer.php | Added ability validation and retrieval before calling factory methods |
| includes/Domain/Tools/RegisterAbilityAsMcpTool.php | Refactored to accept WP_Ability directly, made methods private |
| includes/Domain/Resources/RegisterAbilityAsMcpResource.php | Refactored to accept WP_Ability directly, made methods private |
| includes/Domain/Prompts/RegisterAbilityAsMcpPrompt.php | Refactored to accept WP_Ability directly, made methods private |
| includes/Handlers/* | Added comments explaining ability validation assumptions |
| tests/Unit/* | Updated test calls and removed invalid ability test cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
This was referenced Aug 30, 2025
galatanovidiu
approved these changes
Sep 4, 2025
Contributor
galatanovidiu
left a comment
There was a problem hiding this comment.
LGTM! Changes look correct, and the cleanup is solid.
There are a few more problems related to the compatibility, but they can be resolved on another PR. #39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates compatibility with the initial v0.1.0 release of the
abilities-apiand cleans up the unnecessary boilerplate from theRegisterAbilityAs*factories.More specifically,
RegisterAbilityAs*::make()now takes the actualWP_Abilityinstead of the name, and internal factory methods have been madeprivate. Methods/tests that are no longer necessary have been removed.Why
https://github.com/WordPress/abilities-api/releases/tag/v0.1.0