dev!: refactor non-registry functionality from Core/McpAdapter
#26
Conversation
Core/McpAdapter Core/McpAdapter
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MCP adapter by moving dependency checks and initialization logic from the Core/McpAdapter class to the main Plugin class, following the Single Responsibility Principle.
- Moved dependency validation logic from
McpAdaptertoPlugin - Simplified
McpAdapterto focus solely on server registry functionality - Updated type annotations and class declarations for better type safety
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| includes/Plugin.php | Added dependency checking logic and improved type annotations |
| includes/Core/McpAdapter.php | Removed dependency checking, initialization state tracking, and debugging methods to focus on server registry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
What
This PR cleans up the
Core/McpAdapterserver registry, by (re)moving functionality that is unused or unrelated to server registry handling.Why
SRP - now that we have a
Pluginwrapper we don't need the extra complexity/boilerplate.How
See diff comments.