这是indexloc提供的服务,不要输入任何密码
Skip to content

Initial dark mode support via darkmodelib #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ozone10
Copy link
Contributor

@ozone10 ozone10 commented Jul 4, 2025

Currently dark mode depends on system setting and is only supported on Windows 10 build 19045 and Windows 11 on x64 or arm64. There is no dark mode setting implemented yet.

Only vs2022 variants were tested, but x86 and arm builds should work with older vs2017 and vs2019.

Unfortunately I will be busy for at least one week, so won't be able to work on this PR for now.

fix #396

@ozone10 ozone10 force-pushed the DarkModeInitialSupport branch from 3ebb6b1 to 7ec1cd4 Compare July 4, 2025 17:35
@Neustradamus
Copy link

@ozone10: Nice, thanks!

@sdottaka
Copy link
Member

sdottaka commented Jul 5, 2025

Thank you for the PR. Once I finish working on my current PR, I'd like to test this one in various scenarios.
By the way, do you plan to support switching between dark and light mode dynamically while the application is running in the future?

@ozone10
Copy link
Contributor Author

ozone10 commented Jul 5, 2025

@sdottaka
it should be possible, but I am not familiar with MFC, and how WinMerge saves settings. I will probably leave setting implementation to you and provide help if needed.

@ozone10 ozone10 force-pushed the DarkModeInitialSupport branch from 17de938 to d4ffded Compare July 26, 2025 06:15
@ozone10 ozone10 force-pushed the DarkModeInitialSupport branch from d4ffded to aa528b2 Compare July 26, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Dark mode
3 participants