这是indexloc提供的服务，不要输入任何密码
Skip to content

Adjust the steps to process a context's regular task queue #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Adjust the steps to process a context's regular task queue #2311

merged 1 commit into from
Apr 1, 2021

Conversation

@padenot
Copy link
Member

@padenot padenot commented Mar 26, 2021 •
edited by pr-preview bot
Loading

Thanks to Gregory Terzian for reporting and outlining the patch.

This fixes #2302.

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Mar 26, 2021, 10:08 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@padenot
Adjust the steps to process a context's regular task queue
f143c4b 
Thanks to Gregory Terzian for reporting and outlining the patch.

This fixes #2302.
@padenot padenot requested a review from hoch March 26, 2021 10:07
@padenot padenot self-assigned this Mar 26, 2021
hoch
hoch reviewed Mar 26, 2021
View reviewed changes
index.bs
3. While <var>task count</var> is not equal to 0, execute the following steps:
1. Let <var>oldest task</var> be the first runnable task in <var>task queue</var>, and remove it from <var>task queue</var>.
2. Set the rendering loop's currently running task to <var>oldest task</var>.
3. Perform <var>oldest task</var>'s steps.
Copy link
Member

@hoch hoch Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens the step 3 throws?

Copy link
Member Author

@padenot padenot Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing. It can be logged on the console of course.

I didn't found a test for this in WPT so I added one: https://phabricator.services.mozilla.com/D110410 (this is merged automatically into the main repo).

Copy link
Member

@hoch hoch Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@padenot padenot merged commit 8865bba into main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoch hoch hoch approved these changes

Assignees

@padenot padenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve definition of regular tasks processing.

3 participants

@padenot @hoch