Replace "queue a task" with "queue a media element task" #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padenot
requested changes
Mar 23, 2021
Member
padenot
left a comment
There was a problem hiding this comment.
This doesn't work, because a media element task source is a property of a media element, and we don't have a media element:
Each media element has a unique media element event task source.
here: https://html.spec.whatwg.org/multipage/media.html#media-element-event-task-source
Member
Author
|
We can easily do "Each BaseAudioContext has a unique media element event task source." |
Member
Author
|
@padenot Here's my reasoning behind this change: I don't think we want to create a new BaseAudioContext Task Source just for this reason. |
Member
Author
|
@padenot Is there anything else needs to be done here? |
Member
Author
|
Thanks for the review, @padenot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2095.
This replaces all instances of "queue a task" with "queue a media element task" to clarify the task source. See #2095 (comment).
Preview | Diff