-
Notifications
You must be signed in to change notification settings - Fork 172
Fix #2032: ABSN extrapolates the last output #2256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2032: ABSN extrapolates the last output #2256
Conversation
Update `playbackSignal` to mention that extrapolation is used to compute the output sample when the buffer is not looping and we're at the end of the buffer but need output a sample after the end of the buffer but before the next output sample frame.
|
cc @karlt. |
|
This looks sensible, but @karlt knows more about this. |
|
I understand that @rtoy and I see this somewhat differently. I would suggest just removing "between" from the text in the previous paragraph "UA-supplied algorithm that interpolates -between- sample frames in the neighborhood of position". If "interpolates" is not considered generic enough to support values outside the provided buffer samples, then it can be replaced with "interpolates or extrapolates". I would be happy that using "extrapolates" in this way would also include UA-specific sinc function approximations. |
|
Sorry for the delay @karlt
I'm fine with removing "between" as you suggest. I'm not sure what you're suggesting for the rest of the new text, though. I don't think sinc interpolators are forbidden. It might be unexpected if users say |
If "between" is removed, I'm suggesting that there is no need to add a new paragraph. i.e. modification to the preceding paragraph is sufficient to remove implication that interpolation (or extrapolation) happens only between samples. |
That's fine with me. I've made the proposed changes. |
Minor editorial change to make it clear that we're talking about the variables in the algorithm rather than some generic term, especially for "position".
|
@karlt says these changes are ok. I'm going to land this now. |
Update
playbackSignalto mention that extrapolation is used to compute the output sample when the buffer is not looping and we're at the end of the buffer but need output a sample after the end of the buffer but before the next output sample frame.Preview | Diff