这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix compression curve diagram #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

Fix compression curve diagram #2277

merged 1 commit into from
Nov 19, 2020

Conversation

@padenot
Copy link
Member

@padenot padenot commented Nov 16, 2020

The knee comes after the threshold, and is added to it, so the soft knee
starts at the treshold.

@padenot
Fix compression curve diagram
198e3b3 
The knee comes after the threshold, and is added to it, so the soft knee
starts at the treshold.
@padenot
Copy link
Member Author

padenot commented Nov 16, 2020

https://github.com/WebAudio/web-audio-api/pull/2277/files?short_path=7b72c9b#diff-7b72c9b801345c6cd8c520be21197c028322286e8ba7ca8bd0f55ae28afc26bb shows the difference.

rtoy
rtoy approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@rtoy rtoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What did you use to create this image? Should the source be in the repo? We've have the source Graffle files for all of the images that used Graffle.

@rtoy
Copy link
Member

rtoy commented Nov 16, 2020

Not sure what's up with bikeshed. Some intermittent data issue?

@padenot
Copy link
Member Author

padenot commented Nov 16, 2020

Looks good. What did you use to create this image? Should the source be in the repo? We've have the source Graffle files for all of the images that used Graffle.

I used Inkscape, an SVG editor that is free software. The source is the file itself :-).

Unclear what's up with bikeshed.

@rtoy
Copy link
Member

rtoy commented Nov 16, 2020

Looks good. What did you use to create this image? Should the source be in the repo? We've have the source Graffle files for all of the images that used Graffle.

I used Inkscape, an SVG editor that is free software. The source is the file itself :-).
Heh. Ok.

Unclear what's up with bikeshed.
Yeah. I don't have this problem when I build locally. I even updated my copy of bikeshed to the latest version just now.

@padenot
Copy link
Member Author

padenot commented Nov 18, 2020

Same, but I also retriggered the travis build, and it still fails.

@padenot padenot merged commit b01e2a1 into WebAudio:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtoy rtoy rtoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@padenot @rtoy