Snp test #13
Merged
Snp test #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace abi.ReportCertsToProto() with direct proto.Unmarshal() to bypass strict guest policy bit 17 validation that was failing - Change protojson.Marshal() to proto.Marshal() for binary protobuf output Signed-off-by: wkk <wkk@example.com>
- Remove fmt.Println debug statements from cmd/agent/main.go - Remove fmt.Println debug statements from pkg/atls/certificate_provider.go - Remove fmt.Println debug statements from pkg/attestation/azure/snp.go Signed-off-by: wkk <wkk@example.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
|
Caution Review failedThe pull request is closed. WalkthroughSwitches SEV/SNP attestation serialization from JSON to protobuf binary, updates vTPM TEE attestation handling to unmarshal protobuf directly into sevsnp.Attestation, and performs a minor formatting cleanup in Azure SNP code. No public APIs changed; error messages adjusted accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant SEVQuoteProvider as SEV QuoteProvider
participant vTPM as vTPM Attestation
participant Proto as Protobuf
Caller->>SEVQuoteProvider: Request SEV/SNP quote
SEVQuoteProvider->>Proto: Marshal quote (binary)
Proto-->>SEVQuoteProvider: []byte (protobuf)
SEVQuoteProvider-->>Caller: Quote bytes (protobuf)
Caller->>vTPM: Provide TEE attestation bytes
vTPM->>Proto: Unmarshal bytes → sevsnp.Attestation
Proto-->>vTPM: sevsnp.Attestation or error
vTPM-->>Caller: Processed attestation (unchanged flow)
note over SEVQuoteProvider,Proto: Changed: JSON → binary protobuf
note over vTPM,Proto: Changed: direct protobuf unmarshal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes
Summary by CodeRabbit