Begrudgingly add eslint back #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
Member
|
Everything about this PR is excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alice PTAL.
I really dislike ESLint because it mixes style guide enforcement with error checking and is super wonky to configure.
Having said that, as soon as I published v3.0 someone pointed out that I had snuck an untranspiled
constin there.This PR adds ESLint back but scopes it to only lint the
src/focus-ring.jsfile, and to only check that we're not using ES2015 features. It does not try to do style guide enforcement via ESLint (instead it defers to Prettier). Finally, the PR adds a precommit hook to run ESLint against any file changes tosrc/focus-ring.jsand bail if it fails.