Remove dist #73
Merged
Remove dist #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice
approved these changes
Nov 15, 2017
17a5f39 to
935b046
Compare
alice
approved these changes
Nov 15, 2017
|
|
||
| _We recommend only using versions of the polyfill that have been published to npm, rather than | ||
| cloning the repo and using the source directly. This helps ensure the version you're using is stable | ||
| and thoroughly tested. If you do want to build from source, make sure you clone the latest tag._ |
Collaborator
Author
There was a problem hiding this comment.
I'm going to add that after this change cuz I'm scared to touch this wonky rebase again :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #72.
This removes/ignores the
distfolder and adds a note to the README that tells devs to only use a version of the polyfill that has been published to npm. This is to prevent noise on our PRs (which always require rebuildingdist) and because we don't keep a stable master branch so using the source directly may lead to breakages.Adds a
prepublishOnlyhook to thepackage.jsonto always run our tests and create a build beforenpm publishcompletes.Updates the demo to use unpkg so the hosted page always runs the latest polyfill on npm. Also includes polyfill.io link in the demo to polyfill classList in old IE.