Reduce bundle size by defining pointerMoveEvents array #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of 18 almost identical lines, use pointerMoveEvents array to keep track of all listeners to add/remove in addInitialPointerMoveListeners and removeInitialPointerMoveListeners respectively.
Contributor
|
Have you compared the gzipped size of the bundle? “Almost identical” means you’ll have a very good compression ratio. |
Contributor
|
@wojtekmaj - can you join the WICG to appease the IPR bots? Thanks! :) |
Collaborator
|
hm it seems like a bunch of tests are failing. Were they passing for you locally? I'm wondering if some part of our setup is busted. |
Contributor
Author
|
Looks like the tests are failing because Array.forEach is not supported on IE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of 18 almost identical lines, use pointerMoveEvents array to keep track of all listeners to add/remove in addInitialPointerMoveListeners and removeInitialPointerMoveListeners respectively.