Set an attribute on the document in addition to the class #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only a class is added to the document. This makes it difficult if you are using a framework which overwrites your classes. This mirrors the solution that is already in place for this same issue.
Contributor
|
@ivoilic Can you please join the WICG to appease the IPR bots? |
Author
|
@yoavweiss I've joined WICG and updated the PR due to a typo. Sorry for not doing so before I submitted the PR. |
Contributor
|
@ivoilic no worries :) The IPR bots are still not happy. Did you link your GH account with your W3C account? |
Author
|
@yoavweiss Yes, I just forced it to check again and it looks like it went through! |
Author
|
Any chance of getting this merged? This is a change that shouldn't have a negative impact on existing user and would be of great benefit to many. |
robdodson
approved these changes
Apr 3, 2020
Collaborator
|
published a v5.1.0 release with this in it. thank you! |
Author
|
@robdodson 🎉 Great! Although I just realized I probably should have updated the docs in this PR as well. |
ivoilic
pushed a commit
to ivoilic/focus-visible
that referenced
this pull request
Apr 7, 2020
robdodson
pushed a commit
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only a class is added to the document. This makes it difficult if you are using a framework which overwrites your classes. This mirrors the solution that is already in place for this same issue. See issue #179.