Check if element has data-focus-visible-added attribute on blur
#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdodson
reviewed
May 15, 2018
src/focus-visible.js
Outdated
| if (e.target.classList.contains('focus-visible')) { | ||
| if ( | ||
| e.target.classList.contains('focus-visible') || | ||
| el.hasAttribute('data-focus-visible-added') |
Collaborator
There was a problem hiding this comment.
It doesn't look like el is in scope here. Did you mean e.target?
Contributor
Author
There was a problem hiding this comment.
I did indeed! Sorry copypasta... fixed.
Collaborator
|
looks good to me. I can merge once travis gets back to us :) |
Contributor
Author
|
Great thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve an issue with React, if the classes are updated on render the
focus-visibleclass is removed as React is unaware of it. This could happen when the element should still be focused, one example being a switch component that's toggled with the keyboard updating the classes.