Add support for styling focus for ARIA controls requiring managed focus #64
Conversation
| * @return {Boolean} | ||
| */ | ||
| function keyIsValid(e) { | ||
| var keyCode = e.keyCode; |
There was a problem hiding this comment.
e.keyCode is deprecated. Use e.code instead.
See https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode.
There was a problem hiding this comment.
Never mind. As Rob pointed out, KeyboardEvent.code is not supported in Internet Explorer.
Thanks for the heads up @robdodson.
|
It looks like KeyboardEvent.code is not supported in Internet Explorer,
according to the MDN support tables.
…On Wed, Jan 17, 2018, 7:26 AM Stephan de Vries ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dist/focus-ring.js
<#64 (comment)>:
> @@ -244,6 +273,35 @@ function init() {
el.removeAttribute('data-focus-ring-added');
}
+ /**
+ * Validate the key we're handling should result in the application of the
+ * `focus-ring` class.
+ * @param {Event} e
+ * @return {Boolean}
+ */
+ function keyIsValid(e) {
+ var keyCode = e.keyCode;
e.keyCode is deprecated. Use e.code instead.
See https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#64 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBFDeMpxkdbV_4ZivLWXVhCtyBNRmz9ks5tLhEngaJpZM4QQTTU>
.
|
|
I think I'm going to close this, though I definitely appreciate the work put into it. My thinking on this is that any control, if interacted with using a keyboard, should probably show focus states. I can't off the top of my head think of one where you wouldn't want this? For keyboard shortcuts that move focus to an interactive control, you probably want a For keyboard shortcuts that move focus to a new region in the page, like into a sidebar or modal window, I think you want a focus navigation start point API (today browsers do this but developers can't call it). This would let you avoid the annoying tabindex=-1 trick just to move the focus start point, and you wouldn't need to keep applying |
This PR is a proof of concept and aims to extend
focus-ringsupport to ARIA controls requiring managed focus.Goals for this approach were
focus-ringclass is applied to native HTML controls remain unchanged.aria-activedescendant